New Yorkers continue to flee state in large numbers
"United Van Lines, which has tracked customers' state-to-state migration patterns for 40 years, says New York had the third highest rate of residents moving to other states in 2017. The Empire State has fallen from No. 2 between 2012-2015, but has ranked in the top three outbound states for seven years in a row. The study found the majority of moves to and from New York state -- 61 percent -- were outbound last year. Only two states had higher rates of exodus: Illinois and New Jersey."
This is fairly consistent with the Census Out-Migration estimates, and what you hear on the street, so I'm sure this is true. That said, the state is not losing population, because New York City is a mecca for immigrants from other countries, and indeed the New York City Metropolitan-area is only expected to increase in population compared to the rest of the state.